Skip to content

fix: dismiss the move to spark intro in outcome waits - #306

Merged
ovitrif merged 2 commits into
mainfrom
feat/move-to-spark
Nov 10, 2026
Merged

ovitrif merged 2 commits into
mainfrom
feat/move-to-spark

Conversation

@ovitrif

@ovitrif ovitrif commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This PR adds the Move to Spark intro recovery to the selector action/outcome waits.

tap() already dismisses the intro with Later when it covers its target (#297). tapAndExpect, tapStationaryAndExpect and typeAndExpect from #296 wait for their target without that recovery. The send specs now tap Send through tapAndExpect, so when the intro surfaces on home the tap times out.

This failed send_3 on synonymdev/bitkit-android#1774: the intro showed as the Send tap started, and the wait ran out 30 s later with the intro still covering home.

send_2 reads the total balance right after each Close. The intro can surface on home a moment later and hide it, so those reads now run under the same recovery.

Test

tapAndExpect, tapStationaryAndExpect and typeAndExpect waited for their target without the Move to Spark intro recovery that tap() has, so the intro covering home failed send_2 and send_3.
@ovitrif ovitrif self-assigned this Nov 10, 2026
@ovitrif
ovitrif requested review from piotr-iohk and pwltr November 10, 2026 13:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T13:12:22.873489Z 7830527 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Wraps the target waits in tapAndExpect, tapStationaryAndExpect and typeAndExpect in withMoveToSparkIntroRecovery, so the Move to Spark intro is dismissed with Later and the wait retried once, matching what tap() already does. Reviewed 7830527, light tier (static).

What I checked, and 4 candidates I ruled out

Read in full: test/helpers/outcome.ts; in test/helpers/actions.ts, tap, dismissMoveToSparkIntroIfShown, withMoveToSparkIntroRecovery
Build: skipped, the PR runner could not read the author's permission on this repo and fails closed, so tsc, eslint and the unit tests were not run here
CI: no checks reported on the branch

Ruled out

  • Stale handle on retry in tapAndExpect: current is the lazy elementById chain, re-resolved by waitForDisplayed, the same pattern tap() uses with the same recovery.
  • Stale readiness state in tapStationaryAndExpect: each poll resets previous and ready and a covered target never sets them, so the retry starts clean and two matching samples are still required.
  • Doubled wall time: a recovered wait can take two timeouts, but only when the intro was actually dismissed; the outcome wait in actAndExpect starts after the action, so its own timeout is unchanged.
  • Intro appearing after the click, during the outcome wait: no recovery there, but nothing shows the intro surfacing over an open sheet, and the reported failures were in the pre-tap wait.

Merge confidence: 4/5, not built here and no unit test drives the recovery path in the outcome helpers.

The intro can surface on home a moment after Close, so send_2's total balance reads now run under the same recovery.
@ovitrif

ovitrif commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator Author

28b00ed: send_2 failed on the rerun after Close, when the intro covered home during its total balance read. Those reads in send.e2e.ts now run under withMoveToSparkIntroRecovery. send_3 passed on the rerun with the first commit.

@pwltr pwltr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 28b00ed.

No consequential correctness finding was established in the readiness-recovery helpers and payment-balance assertion changes. Recovery retries waits and reads; the inspected clicks, input mutations and payment submissions remain outside the retry callbacks. This conclusion covers static source inspection.

Review details

General review

Model: GPT-6.1 Sol

Reasoning effort: high

@ovitrif

ovitrif commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator Author

Merging: approved by @pwltr at 28b00ed, and the repository runs no PR checks. synonymdev/bitkit-android#1774's E2E runs fall back to main once this lands.

@ovitrif
ovitrif merged commit 5c8ad99 into main Nov 10, 2026
@ovitrif
ovitrif deleted the feat/move-to-spark branch November 10, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants